x***@nokia.com
2011-10-03 06:46:33 UTC
+1.
Also, there're other left overs from QtMobility. We have at least these two files copied in different places:
qlatin1constant.h - use QStringLiteral
qmobilitypluginsearch.h - use QFactoryLoader (as suggested in QtLocation)
Comments?
================
Xizhi Zhu (Steven)
Software Engineer @ Qt Development Frameworks
Nokia
Mobile: +358 (0)50 480 1247
________________________________________
From: qt5-feedback-bounces+xizhi.zhu=***@qt.nokia.com [qt5-feedback-bounces+xizhi.zhu=***@qt.nokia.com] on behalf of Potter Lorn (Nokia-MP-Qt/Brisbane)
Sent: Monday, October 03, 2011 9:25 AM
To: qt5-***@qt.nokia.com
Subject: [Qt5-feedback] QMetaObjectBuilder in QtDeclarative and QtSystems
Hi,
Currently, there are 3 instances of QMetaObjectBuilder, in QtDeclarative, QtSystems
(serviceframework) and QtSystems (publish and subscribe). There are only trivial changes between
these existing versions of QMetaObjectBuilder private class.
Any objections if I add a QMetaObjectBuilder to qtbase in qtcorelib, so to remove code duplication,
(and I can use it as well)?
I will use the code from QtDeclarative module.
The respective owners of those modules/code should then probably remove their versions and convert
their code to using the one in QtBase.
comments?
--
Lorn 'ljp' Potter
Software Engineer, Nokia, Qt R & D
Also, there're other left overs from QtMobility. We have at least these two files copied in different places:
qlatin1constant.h - use QStringLiteral
qmobilitypluginsearch.h - use QFactoryLoader (as suggested in QtLocation)
Comments?
================
Xizhi Zhu (Steven)
Software Engineer @ Qt Development Frameworks
Nokia
Mobile: +358 (0)50 480 1247
________________________________________
From: qt5-feedback-bounces+xizhi.zhu=***@qt.nokia.com [qt5-feedback-bounces+xizhi.zhu=***@qt.nokia.com] on behalf of Potter Lorn (Nokia-MP-Qt/Brisbane)
Sent: Monday, October 03, 2011 9:25 AM
To: qt5-***@qt.nokia.com
Subject: [Qt5-feedback] QMetaObjectBuilder in QtDeclarative and QtSystems
Hi,
Currently, there are 3 instances of QMetaObjectBuilder, in QtDeclarative, QtSystems
(serviceframework) and QtSystems (publish and subscribe). There are only trivial changes between
these existing versions of QMetaObjectBuilder private class.
Any objections if I add a QMetaObjectBuilder to qtbase in qtcorelib, so to remove code duplication,
(and I can use it as well)?
I will use the code from QtDeclarative module.
The respective owners of those modules/code should then probably remove their versions and convert
their code to using the one in QtBase.
comments?
--
Lorn 'ljp' Potter
Software Engineer, Nokia, Qt R & D