Discussion:
A micro API review: for V3(md5) and V5(sha1) in QUuid
l***@nokia.com
2011-12-09 11:28:58 UTC
Permalink
Hi, all,

The original task is:
http://bugreports.qt.nokia.com/browse/QTBUG-23071

And the change is:
http://codereview.qt-project.org/10803

For the API name, we need a micro API review:
Set 1:
createUuidMd5()
createUuidSha1()

or

createUuidMd5OrSha1()

Set2:
createUuidV3()
createUuidV5()

or

createUuidV3OrV5()

Any other suggestion is also welcome.

Regards,
Liang
l***@nokia.com
2011-12-09 12:01:51 UTC
Permalink
Hi Liang,
Post by l***@nokia.com
Hi, all,
http://bugreports.qt.nokia.com/browse/QTBUG-23071
http://codereview.qt-project.org/10803
createUuidMd5()
createUuidSha1()
or
createUuidMd5OrSha1()
createUuidV3()
createUuidV5()
or
createUuidV3OrV5()
Any other suggestion is also welcome.
These names look ugly. Why not simply QUuid::createUuid(const QUuid &ns,
const QByteArray &baseData, Version v); ?

Lars
Post by l***@nokia.com
Regards,
Liang
_______________________________________________
Qt5-feedback mailing list
http://lists.qt.nokia.com/mailman/listinfo/qt5-feedback
s***@accenture.com
2011-12-09 13:52:40 UTC
Permalink
How about:
QUuid createNamespacedUuid(const QUuid& namespace, const QByteArray& name, QUuid::Version version = QUuid::Sha1);
-----Original Message-----
Sent: Friday, December 09, 2011 11:29
Subject: [Qt5-feedback] A micro API review: for V3(md5) and V5(sha1) in
QUuid
Hi, all,
http://bugreports.qt.nokia.com/browse/QTBUG-23071
http://codereview.qt-project.org/10803
createUuidMd5()
createUuidSha1()
or
createUuidMd5OrSha1()
createUuidV3()
createUuidV5()
or
createUuidV3OrV5()
Any other suggestion is also welcome.
Regards,
Liang
_______________________________________________
Qt5-feedback mailing list
http://lists.qt.nokia.com/mailman/listinfo/qt5-feedback
________________________________
Subject to local law, communications with Accenture and its affiliates including telephone calls and emails (including content), may be monitored by our systems for the purposes of security and the assessment of internal compliance with Accenture policy.
______________________________________________________________________________________

www.accenture.com
João Abecasis
2011-12-09 16:54:31 UTC
Permalink
Post by s***@accenture.com
QUuid createNamespacedUuid(const QUuid& namespace, const QByteArray& name, QUuid::Version version = QUuid::Sha1);
Won't compile ;-)

This discussion moved over to ***@qt-project.org. Please continue it there, or follow it through:

http://lists.qt-project.org/pipermail/development/2011-December/000782.html

Cheers,


João
Jason H
2011-12-12 17:59:57 UTC
Permalink
As long as I can get a UUID without the enclosing {} and preferably any other formatting. I had the fact that I have to convert to string then take mid(1,36)



________________________________
From: "***@nokia.com" <***@nokia.com>
To: qt5-***@qt.nokia.com
Sent: Friday, December 9, 2011 6:28 AM
Subject: [Qt5-feedback] A micro API review: for V3(md5) and V5(sha1) in QUuid

Hi, all,

The original task is:
http://bugreports.qt.nokia.com/browse/QTBUG-23071

And the change is:
http://codereview.qt-project.org/10803

For the API name, we need a micro API review:
Set 1:
createUuidMd5()
createUuidSha1()

or

createUuidMd5OrSha1()

Set2:
createUuidV3()
createUuidV5()

or

createUuidV3OrV5()

Any other suggestion is also welcome.

Regards,
Liang

Loading...